Skip to content

Added support for applying ADC scaling from NDS2 buffers

Duncan Macleod requested to merge github/fork/duncanmmacleod/nds2-adc-scaling into develop

This PR adds two new keywords to TimeSeriesBase.from_nds2_buffer:

  • scaled=True, whether to apply ADC scale and bias settings
  • copy=True, whether to copy the data array to new memory

and exposes these keywords through all TimeSeries*.{fetch,find,get} methods.

This now means that we almost have a consistent interface for auto-applying ADC calibration, since NDS2 and frameCPP access will support it identically. Its just lalframe that doesn't, but I still plan to remove that interface in the near future anyway.

Merge request reports