Skip to content
Snippets Groups Projects

Refactor gwpy.astro to depend on inspiral-range

Merged Duncan Macleod requested to merge github/fork/alurban/inspiral-range into master

Created by: alurban

This PR fixes #1248 (closed) by refactoring the gwpy.astro submodule so that it depends on the new inspiral-range Python package. As a result, the inspiral_range and inspiral_range_psd methods now fully account for cosmological corrections, while the SenseMon method has been refactored into corresponding functions sensemon_range and sensemon_range_psd.

Things to note:

  • The inspiral-range package does not (appear to) support sensitivity metrics based on transient burst sources, so that functionality remains untouched
  • Where possible, I have tried to include references to the inspiral-range package as well as the paper (Belczynski et al. 2014) that lays out the cosmology-corrected range calculation
  • This PR also includes a number of smaller changes that do not affect overall functionality

Closes #1292 (closed).

Merge request reports

Merged by Duncan MacleodDuncan Macleod 3 years ago (Mar 17, 2022 2:00pm UTC)

Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
Please register or sign in to reply
Loading